Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

CI Avoid joblib 1.5.0 in Pyodide #31402

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 22, 2025

Conversation

lesteve
Copy link
Member

@lesteve lesteve commented May 20, 2025

Pyodide CI is broken since joblib 1.5.0 release (see build logs). We haven't uploaded a scikit-learn Pyodide wheel to scientific-python-nightly-wheel and as a consequence
the JupyterLite dev is slightly broken, see #31400 (comment) for more details.

Maybe worth a work-around until there is a joblib 1.5.1 release?

Copy link

✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

Generated for commit: b1acdbc. Link to the linter CI: here

Copy link
Member

@thomasjpfan thomasjpfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe worth a work-around until there is a joblib 1.5.1 release?

I do not think it's worth it. For Pyodide, I rather push for a joblib 1.5.1 release.

@ogrisel ogrisel merged commit cebf45f into scikit-learn:main May 22, 2025
41 checks passed
@lesteve lesteve deleted the joblib-1.4-in-pyodide-ci branch May 22, 2025 09:11
jeremiedbb pushed a commit to jeremiedbb/scikit-learn that referenced this pull request May 30, 2025
jeremiedbb pushed a commit that referenced this pull request Jun 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.