FEAT allow configuring automatically requested metadata #31401
+224
−14
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative to #30946
The approach here is to avoid adding a new function to the base class, and instead handle it via the same
get_metadata_routing
.However, this solution changes the signature of the method, which is not idea. We could at the same time deprecate the method and replace it with a
__sklearn_get_metadata_routing__
method with a new signature, and the__sklearn__
pattern as the rest of the developer API we have now.cc @antoinebaker @ogrisel @StefanieSenger
This is not complete, putting here for us to be able to have a more concrete view of the idea.
The idea is that developer / user code looks like this: