Skip to content

Navigation Menu

Sign in

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

DOC Fix typos in visualization tools docstrings #31351

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
May 13, 2025
Merged

DOC Fix typos in visualization tools docstrings #31351

merged 4 commits into from
May 13, 2025

Conversation

lucyleeow
Copy link
Member

Reference Issues/PRs

Reference both visualization.rst and the section of the user guide explaining det curves, as we have done with other displays (e.g., roc curve)
Also fixes a typo

What does this implement/fix? Explain your changes.

Any other comments?

@lucyleeow lucyleeow added Documentation Quick Review For PRs that are quick to review labels May 12, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented May 12, 2025 •
edited
Loading

✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

Generated for commit: 9c0bdc3. Link to the linter CI: here

ArturoAmorQ
ArturoAmorQ reviewed May 12, 2025
View reviewed changes
Copy link
Member

@ArturoAmorQ ArturoAmorQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @lucyleeow I just merged #31307 without realizing you had done a similar work here. Can you please solve the conflicts? The typo was not addressed in the other PR.

@lucyleeow lucyleeow changed the title DOC Update references in DetCurveDisplay docstring DOC Fix typo in DetCurveDisplay docstring May 12, 2025
@lucyleeow
Copy link
Member Author

Thanks @ArturoAmorQ , done. This becomes a very trivial typo fix now.

@ArturoAmorQ
Copy link
Member

There's still value in typo fixing, mostly because this particular typo also seems to appear in confusion_matrix.py, precision_recall.py and roc_curve.py. Can you please also take care of those?

@lucyleeow
Copy link
Member Author

Thanks, done @ArturoAmorQ

ArturoAmorQ
ArturoAmorQ approved these changes May 13, 2025
View reviewed changes
Copy link
Member

@ArturoAmorQ ArturoAmorQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @lucyleeow ! Merging!

@ArturoAmorQ ArturoAmorQ enabled auto-merge (squash) May 13, 2025 11:38
@ArturoAmorQ ArturoAmorQ disabled auto-merge May 13, 2025 11:47
@ArturoAmorQ ArturoAmorQ changed the title DOC Fix typo in DetCurveDisplay docstring DOC Fix typos in visualization tools docstrings May 13, 2025
@ArturoAmorQ ArturoAmorQ enabled auto-merge (squash) May 13, 2025 11:48
@ArturoAmorQ ArturoAmorQ merged commit 637bb47 into scikit-learn:main May 13, 2025
35 checks passed
@lucyleeow lucyleeow deleted the doc_det branch May 13, 2025 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ArturoAmorQ ArturoAmorQ ArturoAmorQ approved these changes

Assignees
No one assigned
Labels
Documentation module:metrics No Changelog Needed Quick Review For PRs that are quick to review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lucyleeow @ArturoAmorQ
Morty Proxy This is a proxified and sanitized view of the page, visit original site.