Skip to content

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

DOC Add "see also" section to learning_curve docstring #31321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 12, 2025

Conversation

chemousesi
Copy link
Contributor

@chemousesi chemousesi commented May 6, 2025

Reference Issues/PRs

Somewhat related to #31302

What does this implement/fix? Explain your changes.

This PR adds a cross-reference in the learning_curve docstring to LearningCurveDisplay.from_estimator

Any other comments?

done during the probabl unaite workshop

Copy link

github-actions bot commented May 6, 2025

✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

Generated for commit: 843edfa. Link to the linter CI: here

@ArturoAmorQ ArturoAmorQ changed the title added see also on learning curve method in model selection DOC Add "see also" section to learning_curve docstring May 6, 2025
Copy link
Member

@ArturoAmorQ ArturoAmorQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @chemousesi! This should fix the failing CI, but I also suggest a wording tweak.

sklearn/model_selection/_validation.py Outdated Show resolved Hide resolved
@ArturoAmorQ
Copy link
Member

LGTM. Congrats on your first merge @chemousesi! 🎉

@ArturoAmorQ ArturoAmorQ merged commit c1e6494 into scikit-learn:main May 12, 2025
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.