Skip to content

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

DOC Add link to plot_sparse_cov example #31278

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

EngineerDanny
Copy link
Contributor

Reference Issues

Towards #30621

What does this implement / change?

Adds a sphinx-gallery reference to plot_sparse_cov.py in the
GraphicalLassoCV docstring (and GraphicalLasso for symmetry).
No runtime code touched.

Copy link

github-actions bot commented Apr 30, 2025

✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

Generated for commit: fc0c41f. Link to the linter CI: here

Copy link
Contributor

@StefanieSenger StefanieSenger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @EngineerDanny,

thank you for your PR. I like your description to that example, but we need to find a better place to put the link.

The See Also is a place where we aim to link to other API classes or functions, but not examples. (I will add this in the issue description for future contributors.)

Would you mind looking around for another spot where to put the link? Maybe similar as in #30577.

sklearn/covariance/_graph_lasso.py Outdated Show resolved Hide resolved
Copy link
Contributor

@StefanieSenger StefanieSenger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your work, @EngineerDanny. I'm happy with this reference's new spot. Approving.

@adrinjalali, would you like to have a look?

@adrinjalali adrinjalali changed the title DOC Add link to plot_sparse_cov example (Towards #30621) DOC Add link to plot_sparse_cov example May 6, 2025
@adrinjalali adrinjalali merged commit e78fce4 into scikit-learn:main May 6, 2025
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.