Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

DOC: Add reference to digits classification example in LogisticRegression docstring #31258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

yanamis
Copy link

@yanamis yanamis commented Apr 27, 2025

Adds a reference to the digits classification example (plot_digits_classification.py) in the LogisticRegression class docstring, following issue #30621.

Copy link

✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

Generated for commit: d2278d5. Link to the linter CI: here

Copy link
Contributor

@StefanieSenger StefanieSenger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @yanamis,

thanks for your efforts.

I will though close this PR, because the example you added a reference for in _logistic.py does not even contain LogisticRegression and thus the link would be misplaced here.

(Also, and separate from what I wrote above, I would assume that the example doesn't need to be linked any further.)

Please feel free to take on a new task from issue #30621.

@@ -1103,6 +1103,10 @@ class LogisticRegression(LinearClassifierMixin, SparseCoefMixin, BaseEstimator):
>>> clf.score(X, y)
0.97...

See also
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
See also
See Also

This should fix the CI error, since See Also is existing, while See also is not.

@yanamis
Copy link
Author

yanamis commented Apr 29, 2025

Thanks for the feedback, @StefanieSenger. This was my first contribution and I misunderstood how the examples should be matched. I appreciate the clarification and will be more careful next time.

@StefanieSenger
Copy link
Contributor

Hi @yanamis, no worries, we're all learning.
Looking forward to your next contribution. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.