TST use global_random_seed in sklearn/decomposition/tests/test_incremental_pca.py #31250
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
test_incremental_pca_check_projection test_incremental_pca_inverse test_incremental_pca_batch_signs test_incremental_pca_batch_values test_incremental_pca_partial_fit test_incremental_pca_against_pca_random_data test_singular_values
virchan
approved these changes
May 13, 2025
There was a problem hiding this comment.
LGTM! Thanks for the PR, @DeaMariaLeon!
This looks similar to #31213, so I don't think we need a changelog here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Towards #22827
What does this implement/fix? Explain your changes.
I changed the batch size on test_singular_values because it was failing.
Any other comments?
cc @glemaitre