-
-
Notifications
You must be signed in to change notification settings - Fork 25.8k
Added example plot_image_denoising.py in User Guide #30864
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot, @GesaLoof!
The example is already linked several times in the section above ("Generic dictionary learning"), but it uses MiniBatchDictionaryLearning
and thus would rather belong to the section you have linked it to. Since we don't want to pollute the UserGuide too much and aim to pin point examples to their best spots: would you suggest to actually remove a few of the references above, for instance this one or maybe more? What do you think?
Co-authored-by: Stefanie Senger <91849487+StefanieSenger@users.noreply.github.com>
Co-authored-by: Stefanie Senger <91849487+StefanieSenger@users.noreply.github.com>
Hello @GesaLoof, thanks for the changes. The example-linking looks good now. Only one more thing: you have changed and pushed the Thanks a lot! |
Hi @StefanieSenger |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I remember. I am glad you found a solution!
So, this PR looks fine! Thank you for your work!
Can we merge it, @marenwestermann or @adrinjalali ?
Amazing, thank you so much for helping and teaching us how to contribute! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this also reserves to have a link in the MiniBatchDictionaryLearning
docstring.
Reference Issues/PRs
Towards Issue #30621 - Linked example plot_image_denoising.py for Mini-batch dictionary learning
What does this implement/fix? Explain your changes.
Added example plot_image_denoising.py for Mini-batch dictionary learning in the User Guide section 2.5.4.3.
Nothing changed in API documentation.
Any other comments?
@adrinjalali
@StefanieSenger