-
-
Notifications
You must be signed in to change notification settings - Fork 25.9k
ENH: Display parameters in HTML representation #30763
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
145 commits
Select commit
Hold shift + click to select a range
f1540bd
first try
DeaMariaLeon d4e6359
wip
DeaMariaLeon 53e26d6
wip
DeaMariaLeon 27a2934
wip
DeaMariaLeon 1363a90
wip
DeaMariaLeon 1f44e8d
wip
DeaMariaLeon ae18394
wip
DeaMariaLeon bf1774b
wip
DeaMariaLeon fbddf12
wip
DeaMariaLeon 3cedcf4
changed button color
DeaMariaLeon 65a6fe9
Merge remote-tracking branch 'upstream/main' into get-params
DeaMariaLeon 2e7964d
removed svg - use fontawesome
DeaMariaLeon 4fff750
wip
DeaMariaLeon 5da5276
wip
DeaMariaLeon 719871f
single estimator - broken pipe
DeaMariaLeon 6fb104b
fixed pipeline - I think
DeaMariaLeon ea83b49
changing size colors
DeaMariaLeon 4de9ee0
removed name
DeaMariaLeon 79c5133
script at the bottom
DeaMariaLeon 0f7fae9
added temporary Copied message
DeaMariaLeon 2bcf71a
removed console log
DeaMariaLeon 9f580f7
correct margin
DeaMariaLeon 38bc5b5
found non-defaults params
DeaMariaLeon 6e4c191
Font color black when non-default
DeaMariaLeon 6a98da6
added padding to summary
DeaMariaLeon d58137c
correct color
DeaMariaLeon 15a067f
copy button on the left, gave min-width
DeaMariaLeon 235cc59
aligned text
DeaMariaLeon 491b06a
work on green mesage
DeaMariaLeon aaae98f
wip
DeaMariaLeon ded88f4
wip
DeaMariaLeon 430f6a0
draft param_prefix
glemaitre 8b475eb
Merge pull request #2 from glemaitre/params_nested
DeaMariaLeon 8c2588e
added quotation marks to str param, removed repeating code
DeaMariaLeon add9e04
added method names
DeaMariaLeon eeb39b8
added method table
DeaMariaLeon 63c0c0d
styled method table rows
DeaMariaLeon 8997062
added methods params
DeaMariaLeon 0e0dffb
Added missing methods
DeaMariaLeon f89e87d
Escaped methods params
DeaMariaLeon e9907df
Escaped methods params
DeaMariaLeon ca81c1c
adding padding
DeaMariaLeon 00ad17a
cleaned up get params css
DeaMariaLeon ff7fbcc
Cleaned up code
DeaMariaLeon 34c882f
adding hover
DeaMariaLeon 24321fc
wip
DeaMariaLeon e5773dc
split javascript file
DeaMariaLeon 6cefa36
clean up css a bit
DeaMariaLeon e2b27ad
Revert "wip"
DeaMariaLeon 7b42074
js moved to estimator_html_repr.py
DeaMariaLeon 22671cb
stop tracking js file
DeaMariaLeon bfd3287
moved css loading to _estimator_html_repr.py
DeaMariaLeon 3fd9607
fixing columntransf
DeaMariaLeon 6e2f121
fixed long name on columtrnaformer
DeaMariaLeon ea1b36e
[doc build]
DeaMariaLeon abe463e
doc build
DeaMariaLeon 99b1cde
Merge remote-tracking branch 'origin/main' into get-params
DeaMariaLeon 78c9ebb
[doc build]
DeaMariaLeon 5b5bb2c
sanitizing params
DeaMariaLeon 07354e6
remove extra spaces in table values
DeaMariaLeon 6296135
correct sanitize
DeaMariaLeon 2b31b74
correct methods for table
DeaMariaLeon a7a796e
Removed methods from HTML diagram as requested
DeaMariaLeon 9ef2b90
wip to add a new _get_params()
DeaMariaLeon edf9667
Keep get_params original dict per request
DeaMariaLeon 7349c6e
Passing non_default values to ParamsDict
DeaMariaLeon d5d07ae
Added HTML TEMPLATE
DeaMariaLeon 3defd7b
Improve variable names - maybe?
DeaMariaLeon dbecf02
clean up a bit added short docstring
DeaMariaLeon cec643a
Added ellipsis - when param value > 50
DeaMariaLeon 31c3497
adding pretty print - WIP
DeaMariaLeon 71567d3
added important to css so user agent style is not taken
DeaMariaLeon cd7528c
Remove for loop
DeaMariaLeon 0f0f168
Moving out javascript file from estimator_html_repr
DeaMariaLeon 89e88fd
Read path with Path
DeaMariaLeon 39f70a6
removed extra pre label
DeaMariaLeon fc0d0d8
Fix fitted hover color - removed commented css style
DeaMariaLeon 7fae07b
Document params in _write_label_html
DeaMariaLeon 7282bf3
Fix pretty print background
DeaMariaLeon f86be16
Adding tests WIP
DeaMariaLeon 0e4fa18
wip
DeaMariaLeon 679b56e
WIP to add name details to ColumnTransformer elements
DeaMariaLeon 3fdfa49
Adding name_details
DeaMariaLeon 1ebd0ee
fixing test stacking classifier
DeaMariaLeon 3a7b588
clearer name_details logic.. maybe
DeaMariaLeon bf0042f
Check if estimator has _get_params_html
DeaMariaLeon 5fdd295
Improve name_details
DeaMariaLeon 33f7b94
After feedback - partial
DeaMariaLeon d01345d
fixing after feedback - 2
DeaMariaLeon 14bc919
replaced pprint, added ReprHTMLMixin, fixed a docstring test
DeaMariaLeon 8b59a8e
Adding docstrings
DeaMariaLeon c126485
Reworked reprlib on _get_params_html
DeaMariaLeon c7c4161
sanitize value
DeaMariaLeon 01d7b60
Adding mini-test
DeaMariaLeon a93f058
Merge remote-tracking branch 'upstream/main' into get-params
DeaMariaLeon 7a46b87
Wip on tests
DeaMariaLeon 2bbae45
wip
DeaMariaLeon a1ce72a
ordering params and corrected func name after feedback
DeaMariaLeon 375b7a5
after merge
DeaMariaLeon 843d615
correcting css after feedback
DeaMariaLeon 2cb0ec6
refactor after feedback
DeaMariaLeon c602955
Adding missing files
DeaMariaLeon 8502753
Adding test for repr_html
DeaMariaLeon 780697a
empty commit to run CI tests
DeaMariaLeon e5344cc
adding repr_mimebundle test
DeaMariaLeon 94c8d8b
adding context to test
DeaMariaLeon e75546a
fixing test
DeaMariaLeon d2ad614
Merge remote-tracking branch 'upstream/main' into get-params
DeaMariaLeon 306d50e
Merge remote-tracking branch 'upstream/main' into get-params
DeaMariaLeon d670878
MAINT: more refactoring by moving more files into _repr_html
glemaitre 06afd24
fix import
glemaitre 36a9748
fix internal import
glemaitre ccc4517
Merge pull request #3 from glemaitre/move_file
DeaMariaLeon d08263a
Merge remote-tracking branch 'upstream/main' into get-params
DeaMariaLeon 242b656
Modified sklearn.base after feedback
DeaMariaLeon 3222e0f
moving test
DeaMariaLeon 5e7c898
renamed and moved test_estimator_html_repr.py
DeaMariaLeon 9ea4c71
Adding docstrings from feedback
DeaMariaLeon fa966a5
small fix test_base
DeaMariaLeon b9c2365
Forgot this one too
DeaMariaLeon 37e1523
add __init__.py in the tests folder
glemaitre 9220ca0
Merge remote-tracking branch 'upstream/main' into get-params
DeaMariaLeon 8d1fee7
Merge remote-tracking branch 'origin/get-params' into get-params
DeaMariaLeon 73c2c4f
adding tests
DeaMariaLeon 0fe9439
cleaned up after feedback
DeaMariaLeon 5c8d7c9
changed test, cleaned up css - after feedback
DeaMariaLeon 770f5d6
Added fragment for whats_new
DeaMariaLeon 526d0ae
Update sklearn/utils/_repr_html/tests/test_estimator.py
glemaitre cc50796
[doc build] trigger doc
DeaMariaLeon da13276
Merge remote-tracking branch 'upstream/main' into get-params
DeaMariaLeon 7863242
[doc build] trigger doc
DeaMariaLeon b173b7e
Merge remote-tracking branch 'origin/get-params' into get-params
DeaMariaLeon 0d94639
[doc build] trigger doc
DeaMariaLeon 8e2e026
replace fontawesome with base64
glemaitre 8a457af
tweak css a bit more
glemaitre 749f920
Merge pull request #4 from glemaitre/replace_font_awesome
DeaMariaLeon f40b030
[doc build] trigger doc
DeaMariaLeon 851a192
Fix docstring
DeaMariaLeon 17804a2
[doc build] trigger doc
DeaMariaLeon e0ca836
Adding padding
DeaMariaLeon 2110981
Merge remote-tracking branch 'upstream/main' into get-params
DeaMariaLeon 736bc6b
[doc build] trigger doc
DeaMariaLeon f0e7224
[doc build] trigger doc and Merge remote-tracking branch 'upstream/main'
DeaMariaLeon e8dd6b8
Added docstring to _repr_html_inner
DeaMariaLeon 3d5804f
Merge remote-tracking branch 'upstream/main' into get-params
DeaMariaLeon File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
4 changes: 4 additions & 0 deletions
4
doc/whats_new/upcoming_changes/sklearn.base/30763.enhancement.rst
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,4 @@ | ||
- :class:`base.BaseEstimator` now has a parameter table added to the | ||
estimators HTML representation that can be visualized with jupyter. | ||
By :user:`Guillaume Lemaitre <glemaitre>` and | ||
:user:`Dea María Léon <DeaMariaLeon>` |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,2 @@ | ||
# Authors: The scikit-learn developers | ||
# SPDX-License-Identifier: BSD-3-Clause |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.