-
-
Notifications
You must be signed in to change notification settings - Fork 25.9k
DOC add plot_ols_ridge_variance example to the doc #30683
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOC add plot_ols_ridge_variance example to the doc #30683
Conversation
Thanks for your contribution, @sotagg! A concern that I would have is that the example on regression is listed below a part that treats classification. Two of the other examples listed there are also not dealing with What would you think of moving these three up into line 146 and making a new example section there? |
Thank you for the feedback, @StefanieSenger! I agree with your concern and have updated the documentation accordingly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That looks very good. Thank you @sotagg!
@marenwestermann @adrinjalali, would you like to merge this?
@sotagg thanks for the PR. As adding links to examples go, this is fine, but the example itself really needs some improvements. I think we can merge this example with |
Thanks for the suggestion, @adrinjalali! |
@adrinjalali |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You also need to remove the plot_ols_ridge_variance.py
file (you can do with git rm
)
And then, yes, it makes sense to reference this from ridge as well probably.
examples/linear_model/plot_ols.py
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you can remove this file now
@adrinjalali |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, this was missing redirects from the old examples, which I've added.
Reference Issues/PRs
#30621
What does this implement/fix? Explain your changes.
This PR adds a reference to the
plot_ols_ridge_variance.py
example in the Ridge Regression section of the User Guide (linear_model.rst
). This example demonstrates how Ridge regression reduces variance compared to OLS, making it relevant to this section.