Use api_reference as the source of truth for __all__ an __dir__ #30375
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I just saw this, and looks pretty harmless and nice to have. Would you please resolve conflicts? |
adrinjalali
reviewed
Mar 20, 2025
| @@ -27,7 +26,6 @@ | ||
| "AdaBoostRegressor", | ||
| "BaggingClassifier", | ||
| "BaggingRegressor", | ||
| "BaseEnsemble", |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Follow up to #29793
What does this implement/fix? Explain your changes.
When using auto-complete on main I see:
This includes all the objects imported in the file including modules like
functools. With this PR, I get this:Any other comments?
Using
api_referenceas the source of truth leads to some inconsistencies. There are items are not inapi_refernece, but are in an existing__all__. These are listed insklearn/tests/test_imports_public.pyasOBJECTS_NOT_IN_API_REFERENCE. The possible causes are:I added some items into
api_referencethat seems like that should be documented in the first place.