ENH : add_parameter to keep dim in TransformedTargetRegressor #30363
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@glemaitre What do you think about this? |
|
From one of the comments #26530 (comment) it sounds like we change the number of dimensions. That feels like a bug to me -> can't we fix this without having to introduce a new parameter? I'm not sure about the answer to that question, just started looking into this. But maybe someone already knows? |
OmarManzoor
reviewed
Feb 10, 2025
There was a problem hiding this comment.
Thanks for the PR @Irdasset
Instead of adding a new parameter could you handle this by checking the original dimension of y as discussed in the comments on the issue?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Fixes #26530
What does this implement/fix? Explain your changes.
This implement allow the user to preserve the output dim by adding a parameter
preserve_y_dim