Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Add note about pip system requirements for --config-settings #29653

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 18, 2024

Conversation

veeara282
Copy link
Contributor

Reference Issues/PRs

N/A

What does this implement/fix? Explain your changes.

Adds a note to the developers/advanced_installation documentation helping devs troubleshoot problems with the pip install ... --config-settings editable-verbose=true command. Specifically, if the developer's version of pip is <23.1, they will get an error like:

no such option: --config-settings

pip 23.1 adds support for the --config-settings option (see their changelog for details), so this change encourages the developer to upgrade their version of pip to 23.1 or later.

Any other comments?

pip 23.1 deprecated --build-option and --global-option in favor of --config-settings. Should we mention this too?

Copy link

github-actions bot commented Aug 11, 2024

✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

Generated for commit: 1522fb4. Link to the linter CI: here

doc/developers/advanced_installation.rst Outdated Show resolved Hide resolved
@adrinjalali adrinjalali enabled auto-merge (squash) October 17, 2024 09:10
@adrinjalali adrinjalali merged commit 313ec3f into scikit-learn:main Oct 18, 2024
30 checks passed
@lesteve
Copy link
Member

lesteve commented Oct 18, 2024

Let's merge this one, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.