✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

_{Generated for commit: 4798651. Link to the linter CI: here}

No informed opinion on the fix, but it looks this is fixing some failures that I bumped into when looking at lock-file update PR issues and that are due to array-api-strict 2.0.1, see #29276 (comment)

No informed opinion on the fix, but it looks this is fixing some failures that I bumped into when looking at the lock-file update PR issues and that are due to updating to array-api-strict 2.0.1, see #29276 (comment)

Yes it fixes this one error. array-api-strict seems to have included this function in their api but it is not supported in the current version. Therefore we need this specific kind of check.

This looks reasonable? But I am not sure I understand why we need this. Maybe we can add a comment to explain it?

In particular because it seems like searchsorted exists in the namespace, but for some reason we can't use it?

I wrote my comment and then forgot to post it. This is why it looks a bit disconnected. Looking at the error in #29276 (comment) it makes more sense why we need to do something here.

Instead of the proposed fix, I was wondering if we could request a newer version from array-api-strict? It also seems odd that searchsorted exists in the namespace but you aren't allowed to use it, somehow I'd expect it to not exist at all in older versions?

I wrote my comment and then forgot to post it. This is why it looks a bit disconnected. Looking at the error in #29276 (comment) it makes more sense why we need to do something here.

Instead of the proposed fix, I was wondering if we could request a newer version from array-api-strict? It also seems odd that searchsorted exists in the namespace but you aren't allowed to use it, somehow I'd expect it to not exist at all in older versions?

Yes it seems like it didn't exist in older versions but now it seems like they might be planning to support it in the next version. This is the specific error

The function searchsorted requires API version 2023.12 or later, 
but the current API version for array-api-strict is 2022.12

This is what is mentioned on pypi

array-api-strict currently supports the 2022.12 version of the standard. 
2023.12 support is planned and is tracked by 
[this issue](https://github.com/data-apis/array-api-strict/issues/25).

I added a comment with a TODO to remove the additional check when array-api-strict supports the required version.

I found https://data-apis.org/array-api-strict/api.html#array_api_strict.set_array_api_strict_flags so we could select a newer version already?

I found https://data-apis.org/array-api-strict/api.html#array_api_strict.set_array_api_strict_flags so we could select a newer version already?

Nice 👍 Let me try

I think for now we are saying that "to use the experimental array API support, you need to use the latest versions of things".

In particular for array-api-strict I think we should focus on having the newest version working. The package is only meant to be used by projects like scikit-learn to test if their array API code is compatible/correct. Normal users shouldn't use it to get a "array API compatible array", they should use PyTorch, Cupy, Numpy, etc for that.

Overall this means that we should stick to the latest version of it.

(A separate topic is which versions of the array API standard we want to be compatible with, but that is a new discussion.)

I started the CUDA CI workflow for 4798651, results: https://github.com/scikit-learn/scikit-learn/actions/runs/9779581332 - tests pass

Given the discussion and despite my lack of Array API "street cred" I am going to merge this one! What is the worst that could happen 😅?

This will be tested in #29388 that will update to array-api-strict 2.0.1 and we can fix issues if any arise.