-
-
Notifications
You must be signed in to change notification settings - Fork 25.9k
DOC Fix UserWarning in plot_gpr_prior_posterior #29380
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
In the rendered docs this PR raises a Maybe @glemaitre (who bumped the last version in #27910) knows better? |
Merging main to see if #29388 fixes the issue. |
The good news is that merging main did solve the In any case, we can consider the original intention of #29055 to be solved. So thanks again for your contribution, @ovenpickled. Merging! |
Example from commit before merging main had some
Example from last commit doesn't have these warning any more but now there is a warning later in the example in the "Rational Quadradtic kernel" section
By the way there is a typo "Quadractic" (additonal d) should be "Quadratic", maybe worth fixing in this PR? |
I just pushed a commit fixing the typo, if you can double-check c891815 @ArturoAmorQ that would be great. |
Thanks! Nice catch. |
Reference Issues/PRs
Fixes #29055
What does this implement/fix? Explain your changes.
set normalize_y=True in GaussianProcessRegression
Any other comments?
Please let me know if the implemented changes are correct. I am new to Open-source contribution and I am learning how to contribute efficiently. If there are any more changes required, please feel free to revert back.