CI Fix build nightly wheels upload #29295
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adrinjalali
approved these changes
Jun 19, 2024
clin1234
pushed a commit
to clin1234/scikit-learn
that referenced
this pull request
Jun 19, 2024
jeremiedbb
pushed a commit
to jeremiedbb/scikit-learn
that referenced
this pull request
Jul 2, 2024
jeremiedbb
pushed a commit
to jeremiedbb/scikit-learn
that referenced
this pull request
Jul 2, 2024
jeremiedbb
pushed a commit
that referenced
this pull request
Jul 2, 2024
glemaitre
pushed a commit
to glemaitre/scikit-learn
that referenced
this pull request
Oct 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #29293. Probaly the v3 -> v4 artifact actions update changed the path ...
I tested this on my fork with a simpler setup only sdist and making sure that
ls $ARTIFACTS_PATH/*shows something and it does, see build log. There is no staightforward way to test in this PR,[cd build gh]will skip the upload step since the upload step is skipped inside a PR.Previously in #29211, during my testing on my fork, I kind of I expected the workflow to fail because anaconda_upload would fail without token, but I did not think of checking that
ls $ARTIFACTS_PATH/*was showing something oh well 😅Side-comment: in an ideal world we have an automated issue when the nightly wheels upload fails ...