-
-
Notifications
You must be signed in to change notification settings - Fork 25.9k
FIX zero_one_loss
breaks with multilabel and Array API
#29269
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FIX zero_one_loss
breaks with multilabel and Array API
#29269
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fix. Since array API support for those metrics where released in 1.4.0 (I believe), we need to document the fix in the changelog (targeting 1.5.1).
LGTM, besides the missing changelog entry.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM otherwise. Thanks @Tialo
Co-authored-by: Omar Salman <omar.salman2007@gmail.com>
Reference Issues/PRs
What does this implement/fix? Explain your changes.
fixes
zero_one_loss
bug and adds common test for multilabel metrics.Any other comments?
code to reproduce