Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

DOC use semilogx in lasso paths #29264

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 15, 2024

Conversation

mathurinm
Copy link
Contributor

I think this makes the plot easier to read, and simplifies the code.

The only introduced change is that the xaxis are reversed: alpha is now increasing

Before:
image

after
image

Copy link

github-actions bot commented Jun 14, 2024

✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

Generated for commit: 4f89b7c. Link to the linter CI: here

@mathurinm
Copy link
Contributor Author

@glemaitre all green !

Copy link
Member

@glemaitre glemaitre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed, I agree. Thanks @mathurinm

@glemaitre glemaitre changed the title DOC enh use semilogx in lasso paths DOC use semilogx in lasso paths Jun 15, 2024
@glemaitre glemaitre enabled auto-merge (squash) June 15, 2024 15:15
@glemaitre glemaitre merged commit 972e17f into scikit-learn:main Jun 15, 2024
32 checks passed
jeremiedbb pushed a commit to jeremiedbb/scikit-learn that referenced this pull request Jul 2, 2024
@jeremiedbb jeremiedbb mentioned this pull request Jul 2, 2024
11 tasks
jeremiedbb pushed a commit to jeremiedbb/scikit-learn that referenced this pull request Jul 2, 2024
jeremiedbb pushed a commit that referenced this pull request Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.