extreme_stable case for mean_tweedie_deviance #29258
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… extreme stable (power < 0)
ogrisel
reviewed
Jun 14, 2024
|
I put the "no changelog needed" label because array API support for tweedie deviance metrics is not released yet. |
|
Also, please rerun the colab tests once you added the missing test case to this branch. |
|
I triggered a CUDA GPU CI run with the last commit: If green, +1 for merge on my side. EDIT: CUDA tests are green. |
Also just reran the colab tests and they seem to be passing. |
OmarManzoor
approved these changes
Jul 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
towards #26024
related to #28106
What does this implement/fix? Explain your changes.
I noticed that for
mean_tweedie_deviancewe never check for extreme stable cases (power<0) so I added a test for it 😺Upon testing I also found some spots in the actual
mean_tweedie_deviancemethod that we either have missed (still using np) or little errors that break unit tests so I fixed them.Any other comments?
Not sure how to update changelogs or if it's necessary to do that