Skip to content

Navigation Menu

Sign in

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

DOC updates for D2 log loss #28969

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 7, 2024
Merged

DOC updates for D2 log loss #28969

merged 2 commits into from
May 7, 2024

Conversation

OmarManzoor
Copy link
Contributor

Reference Issues/PRs

None. Follow up of #28938

What does this implement/fix? Explain your changes.

  • This updates a reference and some wordings for comments and docs for D2 log loss.

Any other comments?

CC: @jeremiedbb

@OmarManzoor OmarManzoor added this to the 1.5 milestone May 7, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented May 7, 2024 •
edited
Loading

✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

Generated for commit: 38f953a. Link to the linter CI: here

jeremiedbb
jeremiedbb approved these changes May 7, 2024
View reviewed changes
Copy link
Member

@jeremiedbb jeremiedbb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @OmarManzoor

@jeremiedbb jeremiedbb merged commit 1fa3c75 into scikit-learn:main May 7, 2024
30 checks passed
@OmarManzoor OmarManzoor deleted the d2_log_loss_doc_fixes branch May 7, 2024 14:27
jeremiedbb pushed a commit to jeremiedbb/scikit-learn that referenced this pull request May 20, 2024
@OmarManzoor @jeremiedbb
DOC updates for d2_log_loss_score (scikit-learn#28969)
27de47a
@jeremiedbb jeremiedbb mentioned this pull request May 20, 2024
Merged
14 tasks
jeremiedbb pushed a commit that referenced this pull request May 21, 2024
@OmarManzoor @jeremiedbb
DOC updates for d2_log_loss_score (#28969)
1f36417
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeremiedbb jeremiedbb jeremiedbb approved these changes

Assignees
No one assigned
Labels
Documentation module:metrics No Changelog Needed
Projects
None yet
Milestone
1.5
Development

Successfully merging this pull request may close these issues.
2 participants
@OmarManzoor @jeremiedbb
Morty Proxy This is a proxified and sanitized view of the page, visit original site.