Fix tolerance for seed-sensitive test test_pca_solver_equivalence
#28961
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
test_pca_solver_equivalence
|
The test detection is limited 😄 the commit message should be |
test_pca_solver_equivalence
test_pca_solver_equivalence
Yes it's a bit freaky. It needs to be high both for OpenBLAS's arpack solver and for our own randomized SVD solver with default number of power iterations. The latter might be expected but I would not have expected this to be the case for arpack. |
jeremiedbb
pushed a commit
to jeremiedbb/scikit-learn
that referenced
this pull request
May 20, 2024
jeremiedbb
pushed a commit
that referenced
this pull request
May 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #28953.