Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

MAINT pymin_conda_defaults_openblas #28908

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

ogrisel
Copy link
Member

@ogrisel ogrisel commented Apr 29, 2024

This PR does several things to make pymin_conda_defaults_openblas more sensible:

Copy link

github-actions bot commented Apr 29, 2024

✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

Generated for commit: 1066833. Link to the linter CI: here

@ogrisel
Copy link
Member Author

ogrisel commented Apr 29, 2024

I see that I forgot to remove the matching entries from the remove_from call but then I get a weird error message. Let me investigate.

@ogrisel ogrisel marked this pull request as draft April 29, 2024 10:04
@ogrisel ogrisel marked this pull request as ready for review April 29, 2024 12:42
@ogrisel
Copy link
Member Author

ogrisel commented Apr 29, 2024

This should be ready for review.

Copy link
Member

@jeremiedbb jeremiedbb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jeremiedbb
Copy link
Member

Merging before we update the lock files next monday

@jeremiedbb jeremiedbb merged commit dbebec7 into scikit-learn:main May 2, 2024
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.