TST make sure test_pca_sparse passes on all random seeds #28861
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
test_pca_sparse
test_pca_sparse
test_pca_sparse
test_pca_sparse
test_pca_sparse
|
Maybe we could check that |
|
I checked and they're always a lot larger. We're only looking for a max of 10 components. Even with the min density of 0.01, all 10 components always have the same approx explained variance of 0.4%, for all seeds. The kind of randomness I mention here has a very very small impact. It changes the final digit once in while. I think we can ignore it for now, the new tols are robust to that. |
ogrisel
approved these changes
Apr 24, 2024
glemaitre
approved these changes
Apr 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #28857
The array that we're comparing have a very wide range of values, from 1e-8 to 1e0. Having a same rtol for all is kind of problematic. In this PR I introduced an additional atol, useful for the very low values. In the plot below I show the absolute difference of the components vs the absolute value of the components to illustrate the need of an atol:
We see that for very small values of the components, the absolute diff doesn't foolow the same trend as for larger values. It looks like a plateau.
The following plot shows the relative diff of the components vs the absolute values of the components. It's clearly not constant or even upper bounded (if we were to extrapolate for even smaller values). This goes against what we assume when we write
assert_allclose(X1, X2, rtol=constant).This is symptomatic of a general issue that we have through the whole project for comparing arrays element-wise. I made a quick fix here to make the CI green, but I think that it should be improved in general (I've been thinking about that for a while: it's not an easy problem and I haven't found a satisfying solution yet).