Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Fixed TimeSeriesSplit training set size formula #28322

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Jun 24, 2024
Merged

Fixed TimeSeriesSplit training set size formula #28322

merged 7 commits into from
Jun 24, 2024

Conversation

ZiadAmerr
Copy link
Contributor

Reference Issues/PRs

Fixes #28321.

What does this implement/fix? Explain your changes.

This fixes the incorrect behavior of the formula to compute the training set size for TimeSeriesSplit

Any other comments?

ZiadAmerr
ZiadAmerr commented Jan 31, 2024
View reviewed changes
sklearn/model_selection/_split.py Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 31, 2024 •
edited
Loading

✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

Generated for commit: 2c9d3bb. Link to the linter CI: here

ZiadAmerr
ZiadAmerr commented Jan 31, 2024
View reviewed changes
sklearn/model_selection/_split.py Outdated Show resolved Hide resolved
@jeremiedbb jeremiedbb mentioned this pull request Mar 7, 2024
Closed
ZiadAmerr
ZiadAmerr commented Jun 14, 2024
View reviewed changes
sklearn/model_selection/_split.py Outdated Show resolved Hide resolved
jeremiedbb
jeremiedbb approved these changes Jun 24, 2024
View reviewed changes
Copy link
Member

@jeremiedbb jeremiedbb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ZiadAmerr. Just a minor nitpick. Otherwise LGTM.

sklearn/model_selection/_split.py Outdated Show resolved Hide resolved
@ZiadAmerr @jeremiedbb
Minor rephrasing
2c9d3bb 
Co-authored-by: Jérémie du Boisberranger <jeremie@probabl.ai>
@ZiadAmerr
Copy link
Contributor Author

Perfect, all done :)

@jeremiedbb jeremiedbb enabled auto-merge (squash) June 24, 2024 14:09
@jeremiedbb jeremiedbb merged commit ce2d74c into scikit-learn:main Jun 24, 2024
28 checks passed
jeremiedbb added a commit to jeremiedbb/scikit-learn that referenced this pull request Jul 2, 2024
@ZiadAmerr @jeremiedbb
DOC TimeSeriesSplit training set size formula precision (scikit-learn…
387e90f 
…#28322)

Co-authored-by: Jérémie du Boisberranger <jeremie@probabl.ai>
@jeremiedbb jeremiedbb mentioned this pull request Jul 2, 2024
Merged
11 tasks
jeremiedbb added a commit to jeremiedbb/scikit-learn that referenced this pull request Jul 2, 2024
@ZiadAmerr @jeremiedbb
DOC TimeSeriesSplit training set size formula precision (scikit-learn…
16dcc91 
…#28322)

Co-authored-by: Jérémie du Boisberranger <jeremie@probabl.ai>
jeremiedbb added a commit that referenced this pull request Jul 2, 2024
@ZiadAmerr @jeremiedbb
DOC TimeSeriesSplit training set size formula precision (#28322)
c16c495 
Co-authored-by: Jérémie du Boisberranger <jeremie@probabl.ai>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeremiedbb jeremiedbb jeremiedbb approved these changes

Assignees
No one assigned
Labels
module:model_selection
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TimeSeriesSplit Train Size formula correction
2 participants
@ZiadAmerr @jeremiedbb
Morty Proxy This is a proxified and sanitized view of the page, visit original site.