Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

ENH Add support for np.nan values in SplineTransformer #28043

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 59 commits into
base: main
Choose a base branch
Loading
from
Open

ENH Add support for np.nan values in SplineTransformer #28043

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
59 commits
Select commit Hold shift + click to select a range
4255470
added indicator
StefanieSenger Dec 20, 2023
812ae00
added splines full of 0 for nan input in transform
StefanieSenger Dec 21, 2023
0ad4f5e
Merge branch 'main' into nan_SplineTransformer
StefanieSenger Jan 8, 2024
f0f7d5e
fixed extrapolation='error' related error
StefanieSenger Jan 8, 2024
a38ee69
fixed _get_base_knot_positions so spline parameters are build correctly
StefanieSenger Jan 9, 2024
4c9a867
exclude knots='quantile' from camparison check
StefanieSenger Jan 9, 2024
f7f7ca4
fixed issues from test_common
StefanieSenger Jan 10, 2024
4bbdd4a
little things
StefanieSenger Jan 10, 2024
092eca0
Merge branch 'main' into nan_SplineTransformer
StefanieSenger Feb 29, 2024
5165c6b
calculate indicator based on X passed into transform
StefanieSenger Mar 13, 2024
1a7d134
Merge branch 'main' into nan_SplineTransformer
StefanieSenger Mar 13, 2024
708ae53
add and adjust tests after review
StefanieSenger Mar 15, 2024
1dc3b3c
wording and typo
StefanieSenger Mar 15, 2024
dce1620
Merge branch 'main' into nan_SplineTransformer
StefanieSenger Apr 8, 2024
63ea8aa
Merge branch 'main' into nan_SplineTransformer
StefanieSenger Apr 18, 2024
2ef6623
renaming option constant-->zeros
StefanieSenger Apr 18, 2024
f57f12c
Apply suggestions from code review
StefanieSenger Apr 22, 2024
5d1baeb
changes after review
StefanieSenger Apr 23, 2024
cd956c2
adrins fixes
StefanieSenger Apr 23, 2024
06d0a2b
fix test failure for scipy<=1.10
StefanieSenger Apr 24, 2024
44ddc3e
without removing training whitespace
StefanieSenger Apr 24, 2024
a2b6e8b
improved error message
StefanieSenger Apr 24, 2024
da6eaa0
refactoring BSpline creation for 'error' and 'continue'
StefanieSenger Apr 25, 2024
17ad9c1
refactoring BSpline creation for 'periodic'
StefanieSenger Apr 25, 2024
9047736
refactoring
StefanieSenger Apr 25, 2024
506a18e
more refactoring
StefanieSenger Apr 25, 2024
6d02e6f
fix error related to scipy<=1.10.0
StefanieSenger Apr 29, 2024
2c261c9
delete unused code
StefanieSenger Apr 29, 2024
e9d1c53
raise if nan and sample_weight, facilitate tests
StefanieSenger Apr 30, 2024
e78b12e
calculate bsplines columnwise again
StefanieSenger Apr 30, 2024
45b19f7
Apply suggestions from code review
StefanieSenger May 8, 2024
1fe01ba
changes after review
StefanieSenger May 8, 2024
9a0b7d0
Merge branch 'main' into nan_SplineTransformer
StefanieSenger May 8, 2024
e25f3a8
update changelog
StefanieSenger May 8, 2024
ac276fa
support edge case with whole columns of nans
StefanieSenger May 8, 2024
ffb1012
Apply suggestions from code review
StefanieSenger May 13, 2024
71fe537
get nan_mask feature-wise
StefanieSenger May 13, 2024
2344988
Apply suggestions from code review
StefanieSenger May 13, 2024
25dce72
refactoring tests
StefanieSenger May 13, 2024
2d77a27
Merge branch 'main' into nan_SplineTransformer
StefanieSenger May 13, 2024
a4129fc
re-put fix for older scipy versions outside of loop through features
StefanieSenger May 14, 2024
9307816
Merge branch 'main' into nan_SplineTransformer
StefanieSenger May 23, 2024
c840f0a
Apply suggestions from code review
StefanieSenger May 23, 2024
c1278a6
satisfy ruff
StefanieSenger May 23, 2024
bd867af
Merge branch 'main' into nan_SplineTransformer
StefanieSenger Oct 9, 2024
55feb20
fix linting
StefanieSenger Oct 9, 2024
407165a
fix FutureWarning for force_all_finite
StefanieSenger Oct 9, 2024
71b09ef
Merge branch 'main' into nan_SplineTransformer
StefanieSenger Jan 6, 2025
da8fcdc
Merge branch 'main' into nan_SplineTransformer
ogrisel Apr 18, 2025
b6239fb
Handle all-nan columns as constant columns
ogrisel Apr 18, 2025
f6ab8f8
update changelog
StefanieSenger May 6, 2025
3f47364
improve comments
StefanieSenger May 7, 2025
656685b
remove erroring behavior for nan and sample_weight and improve other …
StefanieSenger May 15, 2025
6571a12
fix input_tags for nans
StefanieSenger May 15, 2025
a41deb1
add test for sample_weight and nan value handling
StefanieSenger May 15, 2025
6abb0af
fix exception handling for nan input
StefanieSenger May 15, 2025
038ffe8
fix shape mismatch in CI due to sparse-dense conversion
StefanieSenger May 15, 2025
fe27494
Merge branch 'main' into nan_SplineTransformer
StefanieSenger May 15, 2025
4b0cb85
Apply suggestions from code review
StefanieSenger May 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions 2 doc/whats_new/upcoming_changes/sklearn.preprocessing/28043.enhancement.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
- :class:`preprocessing.SplineTransformer` can now handle missing values with the
parameter `handle_missing`. By :user:`Stefanie Senger <StefanieSenger>`.
Loading
Loading
Morty Proxy This is a proxified and sanitized view of the page, visit original site.