Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

DOC Fix monotonic note in calibration.rst #27792

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 16, 2023

Conversation

lucyleeow
Copy link
Member

@lucyleeow lucyleeow commented Nov 16, 2023

What does this implement/fix? Explain your changes.

I think this was just a typo as 'sigmoid' is based on Platt’s 'logistic' model. Platt preserves rank, I think.

Any other comments?

cc @lorentzenchr @ogrisel who were active in the original PR #25900

Copy link

✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

Generated for commit: 361adb1. Link to the linter CI: here

Copy link
Member

@lorentzenchr lorentzenchr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for detecting and fixing it.

@lorentzenchr lorentzenchr merged commit 450fef9 into scikit-learn:main Nov 16, 2023
@lucyleeow lucyleeow deleted the doc_calb_mono branch November 16, 2023 07:29
REDVM pushed a commit to REDVM/scikit-learn that referenced this pull request Nov 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.