-
-
Notifications
You must be signed in to change notification settings - Fork 25.9k
MAINT check status of codecov #25875
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I don't think so: patch:
default:
# Be tolerant on slight code coverage diff on PRs to limit
# noisy red coverage status on github PRs.
# Note: The coverage stats are still uploaded
# to codecov so that PR reviewers can see uncovered lines
target: auto
threshold: 1% you need to add probably around 200k/100 lines of uncovered code for it to complain ;) |
At least codecov should show up the patch and project details which do not happen on the PR for a while already. |
We checked the upload and this seems to work but the reporting is kind of broken |
I do think so :) 1% is a tolerance on the patch, so if you add 5 lines and 1 is not covered, you have 20% of the patch not covered and codecov should complain |
Maybe doing a "reinstallation" here would help? https://github.com/organizations/scikit-learn/settings/installations/9355 |
"Did you try to switch it off and on?" ;) I will just wait for the build to finish to see the report on the website to see if there is any kind of error. |
You did not wake up codecov but you made numpydoc angry 😄 |
I open a topic on the discourse from the codecov community: https://community.codecov.com/t/codecov-github-app-does-not-report-back-in-github-prs-anymore/4209 |
closing in favor of #25919 |
Codecov should complain