MAINT Added Parameter Validation for datasets.make_circles() #25804
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeremiedbb
reviewed
Mar 13, 2023
| "shuffle": ["boolean"], | ||
| "noise": [Interval(Real, 0, None, closed="left"), None], | ||
| "random_state": ["random_state"], | ||
| "factor": [Interval(Real, 0, 1, closed="both")], |
There was a problem hiding this comment.
According to the validation on line 729, 0 is allowed and 1 is not.
Suggested change
| "factor": [Interval(Real, 0, 1, closed="both")], | |
| "factor": [Interval(Real, 0, 1, closed="left")], |
You can now remove validation on line 729, and check in test_sample_generator if we check for this specific error (in which case you can remove it).
Please also fix the param description in the docstring which should be ìn the range [0, 1)
Thanks for the suggestion @jeremiedbb |
|
I unresolved this #25804 (comment) since the 2 second part of the comment still needs to be addressed. |
|
"left" |
51c20d0 to
fd9bff1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Towards #24862
What does this implement/fix? Explain your changes.
Added parameter validation for
datasets.make_circleAny other comments?
Tests passed
flake8 ./sklearn/datasets/_samples_generator.py,pytest -vl sklearn/tests/test_public_functions.py