-
-
Notifications
You must be signed in to change notification settings - Fork 25.9k
FEA Store the GradientBoostingClassifier
/ GradientBoostingRegressor
OOB Scores as the oob_score(s)_
fitted attributes
#24882
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@ogrisel Would please kindly review this PR? |
GradientBoostingClassifier
GradientBoostingClassifier
GradientBoostingClassifier
GradientBoostingClassifier
OOB Scores as the oob_score(s)_
fitted attributes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this contribution, @awinml.
Co-authored-by: Julien Jerphanion <git@jjerphan.xyz>
Co-authored-by: Julien Jerphanion <git@jjerphan.xyz>
Co-authored-by: Julien Jerphanion <git@jjerphan.xyz>
Co-authored-by: Julien Jerphanion <git@jjerphan.xyz>
Co-authored-by: Julien Jerphanion <git@jjerphan.xyz>
Co-authored-by: Julien Jerphanion <git@jjerphan.xyz>
Co-authored-by: Julien Jerphanion <git@jjerphan.xyz>
Co-authored-by: Julien Jerphanion <git@jjerphan.xyz>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Another pass.
Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that we converge.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Once the comments from @betatim are addressed, LGTM on my side.
Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
GradientBoostingClassifier
OOB Scores as the oob_score(s)_
fitted attributesGradientBoostingClassifier
/ GradientBoostingRegressor
OOB Scores as the oob_score(s)_
fitted attributes
Letting @glemaitre merge once this LGTH. |
Merging Thanks @awinml |
…ed attributes (scikit-learn#24882) Co-authored-by: Julien Jerphanion <git@jjerphan.xyz> Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
Reference Issues/PRs
Fixes #23400
GradientBoostingClassifier
andGradientBoostingRegressor
now exposes out-of-bag scores via theoob_scores_
oroob_score_
attributes.What does this implement/fix? Explain your changes.
Added
oob_scores_
andoob_score_
attributes to Gradient Boosting Estimators to store the Out Of Bag loss.oob_scores_
contains the full history of loss values.oob_score_
stores the last element of oob_scores_ for easy access.