-
-
Notifications
You must be signed in to change notification settings - Fork 25.9k
DOC Update documentation of gradient boosting estimators w/ ranges #22153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
ogrisel
merged 8 commits into
scikit-learn:main
from
genvalen:gradient_boosting_add_param_range_to_docs
Feb 23, 2022
Merged
DOC Update documentation of gradient boosting estimators w/ ranges #22153
ogrisel
merged 8 commits into
scikit-learn:main
from
genvalen:gradient_boosting_add_param_range_to_docs
Feb 23, 2022
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@glemaitre, @ogrisel: this is ready to review for when #21632 is merged in. |
glemaitre
reviewed
Jan 31, 2022
thomasjpfan
reviewed
Feb 7, 2022
Co-authored-by: Thomas J. Fan <thomasjpfan@gmail.com>
Co-authored-by: Thomas J. Fan <thomasjpfan@gmail.com>
Co-authored-by: Thomas J. Fan <thomasjpfan@gmail.com>
thomasjpfan
approved these changes
Feb 7, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the update! LGTM
ogrisel
approved these changes
Feb 23, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM as well!
thomasjpfan
added a commit
to thomasjpfan/scikit-learn
that referenced
this pull request
Mar 1, 2022
…cikit-learn#22153) Co-authored-by: Thomas J. Fan <thomasjpfan@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
This PR requires #21632 to be merged in first.
What does this implement/fix? Explain your changes.
Update
GradientBoostingClassifier
andGradientBoostingRegressor
scalar parameter documentation to include the expected range.Any other comments?
I did not add a range for
warm_start
(bool) since it seemed straightforward in both estimators, but please advise. Thank you.EDIT: docs for
warm_start
have been updated.