Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

DOC Update documentation of gradient boosting estimators w/ ranges #22153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

genvalen
Copy link
Contributor

@genvalen genvalen commented Jan 9, 2022

Reference Issues/PRs

This PR requires #21632 to be merged in first.

What does this implement/fix? Explain your changes.

Update GradientBoostingClassifier and GradientBoostingRegressor scalar parameter documentation to include the expected range.

Any other comments?

I did not add a range for warm_start (bool) since it seemed straightforward in both estimators, but please advise. Thank you.
EDIT: docs for warm_start have been updated.

@genvalen genvalen changed the title [WIP] DOC Update documenation of gradient boosting estimators [WIP] DOC Update documenation of gradient boosting estimators w/ ranges Jan 9, 2022
@genvalen genvalen changed the title [WIP] DOC Update documenation of gradient boosting estimators w/ ranges [MRG] DOC Update documenation of gradient boosting estimators w/ ranges Jan 11, 2022
@genvalen genvalen changed the title [MRG] DOC Update documenation of gradient boosting estimators w/ ranges [WIP] DOC Update documenation of gradient boosting estimators w/ ranges Jan 11, 2022
@genvalen genvalen changed the title [WIP] DOC Update documenation of gradient boosting estimators w/ ranges [MRG] DOC Update documentation of gradient boosting estimators w/ ranges Jan 31, 2022
@genvalen
Copy link
Contributor Author

@glemaitre, @ogrisel: this is ready to review for when #21632 is merged in.

sklearn/ensemble/_gb.py Outdated Show resolved Hide resolved
sklearn/ensemble/_gb.py Outdated Show resolved Hide resolved
sklearn/ensemble/_gb.py Outdated Show resolved Hide resolved
sklearn/ensemble/_gb.py Outdated Show resolved Hide resolved
sklearn/ensemble/_gb.py Outdated Show resolved Hide resolved
sklearn/ensemble/_gb.py Outdated Show resolved Hide resolved
sklearn/ensemble/_gb.py Outdated Show resolved Hide resolved
sklearn/ensemble/_gb.py Outdated Show resolved Hide resolved
sklearn/ensemble/_gb.py Outdated Show resolved Hide resolved
sklearn/ensemble/_gb.py Outdated Show resolved Hide resolved
sklearn/ensemble/_gb.py Outdated Show resolved Hide resolved
genvalen and others added 3 commits February 7, 2022 14:56
Co-authored-by: Thomas J. Fan <thomasjpfan@gmail.com>
Co-authored-by: Thomas J. Fan <thomasjpfan@gmail.com>
Co-authored-by: Thomas J. Fan <thomasjpfan@gmail.com>
@thomasjpfan thomasjpfan changed the title [MRG] DOC Update documentation of gradient boosting estimators w/ ranges DOC Update documentation of gradient boosting estimators w/ ranges Feb 7, 2022
Copy link
Member

@thomasjpfan thomasjpfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update! LGTM

Copy link
Member

@ogrisel ogrisel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as well!

@ogrisel ogrisel merged commit e0ebc78 into scikit-learn:main Feb 23, 2022
@genvalen genvalen deleted the gradient_boosting_add_param_range_to_docs branch February 24, 2022 07:07
thomasjpfan added a commit to thomasjpfan/scikit-learn that referenced this pull request Mar 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.