Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

FIX Fixes memoryview bug in DistanceMetric #19933

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 20, 2021
Merged

FIX Fixes memoryview bug in DistanceMetric #19933

merged 1 commit into from
Apr 20, 2021

Conversation

thomasjpfan
Copy link
Member

@thomasjpfan thomasjpfan commented Apr 20, 2021 •
edited
Loading

Fixes #19932

Fixes the failing tests on main that resulted from #19883

@thomasjpfan thomasjpfan changed the title FIX Fixes memoryview error in DistanceMetric FIX Fixes memoryview bug in DistanceMetric Apr 20, 2021
@jjerphan
Copy link
Member

Thanks @thomasjpfan for your reactiveness. This fixes #19932.

ogrisel
ogrisel approved these changes Apr 20, 2021
View reviewed changes
Copy link
Member

@ogrisel ogrisel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ogrisel
Copy link
Member

ogrisel commented Apr 20, 2021

Let's wait for the CI to be green and merge.

jeremiedbb
jeremiedbb approved these changes Apr 20, 2021
View reviewed changes
Copy link
Member

@jeremiedbb jeremiedbb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. Thanks @thomasjpfan

@jeremiedbb jeremiedbb merged commit ce217db into scikit-learn:main Apr 20, 2021
@glemaitre glemaitre mentioned this pull request Apr 22, 2021
Merged
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ogrisel ogrisel ogrisel approved these changes

@jeremiedbb jeremiedbb jeremiedbb approved these changes

Assignees
No one assigned
Labels
cython module:neighbors
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

FIX Tests modified in #19893 fail on main after integration of #19893
4 participants
@thomasjpfan @jjerphan @ogrisel @jeremiedbb
Morty Proxy This is a proxified and sanitized view of the page, visit original site.