EXA Fix plot_map_data_to_normal.py example legend #19930
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lambda was meant to be on a different line.
thomasjpfan
approved these changes
Apr 20, 2021
There was a problem hiding this comment.
Thank you for the PR @lesteve !
Yes, we can have another PR to improve on the readability of this example.
|
Merging since the test failures are unrelated. |
|
Great thanks! |
glemaitre
pushed a commit
to glemaitre/scikit-learn
that referenced
this pull request
Apr 22, 2021
Lambda was meant to be on a different line.
glemaitre
pushed a commit
that referenced
this pull request
Apr 28, 2021
Lambda was meant to be on a different line.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this implement/fix? Explain your changes.
In this example
\lambdawas very likely meant to be on a different line in the title.mainThis PR
Any other comments?
The title font is probably too small for useful purposes but I tried to increase the font but that did not play well with matplotlib tight layout and I could not fix it in less than 5 minutes ... so maybe for another PR?