FIX Fixes unknown handling for str dtypes in OrdinalEncoder.transform #19888
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glemaitre
reviewed
Apr 14, 2021
doc/whats_new/v1.0.rst
Outdated
| @@ -347,6 +347,9 @@ Changelog | ||
| supporting sparse matrix and raise the appropriate error message. | ||
| :pr:`19879` by :user:`Guillaume Lemaitre <glemaitre>`. | ||
|
|
||
| - |Fix| :meth:`preprocessing.OrdinalEncoder.transfrom` now correctly handles |
There was a problem hiding this comment.
Could you flag it for 0.24.2 instead?
glemaitre
approved these changes
Apr 14, 2021
sklearn/preprocessing/_encoders.py
Outdated
| @@ -150,6 +150,10 @@ def _transform(self, X, handle_unknown='error', force_all_finite=True, | ||
| if (self.categories_[i].dtype.kind in ('U', 'S') | ||
| and self.categories_[i].itemsize > Xi.itemsize): | ||
| Xi = Xi.astype(self.categories_[i].dtype) | ||
| elif (self.categories_[i].dtype.kind == 'O' and | ||
| Xi.dtype.kind == 'U'): | ||
| # categories are objects and Xi are numpy strings |
There was a problem hiding this comment.
You could maybe add that otherwise the string will be truncated
adrinjalali
approved these changes
Apr 18, 2021
thomasjpfan
added a commit
to thomasjpfan/scikit-learn
that referenced
this pull request
Apr 19, 2021
…scikit-learn#19888) * FIX Fixes unknown handling for str X in OrdinalEncoder.transform * DOC Adds whats new * DOC Move to 0.24.2 * DOC Adds reasoning in comment
glemaitre
pushed a commit
to glemaitre/scikit-learn
that referenced
this pull request
Apr 22, 2021
…scikit-learn#19888) * FIX Fixes unknown handling for str X in OrdinalEncoder.transform * DOC Adds whats new * DOC Move to 0.24.2 * DOC Adds reasoning in comment
glemaitre
pushed a commit
that referenced
this pull request
Apr 28, 2021
…#19888) * FIX Fixes unknown handling for str X in OrdinalEncoder.transform * DOC Adds whats new * DOC Move to 0.24.2 * DOC Adds reasoning in comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Fixes #19872
What does this implement/fix? Explain your changes.
When
Xiis of dtype '<U1andself.categories_[i][0]` is 'AA', the following would collapse 'AA' into 'A':This PR converts
Xiinto an object dtype when it sees thatself.categories_[i]is an object dtype.