-
-
Notifications
You must be signed in to change notification settings - Fork 25.9k
CI Add label on PRs modifying Cython code #19850
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Ha that's a shame. Any existing feature request that we could +1 ? Also I'm wondering: is the labeling retroactive and if it's not, is it still useful? |
I can run a small script that does it once for all PRs, if we think the As for this PR, I would add another file for non-module related labeling named
My fork of the labeler puts a cap on the number of labels using the jobs:
triage_file_extensions:
runs-on: ubuntu-latest
steps:
- uses: thomasjpfan/labeler@v2.5.0
continue-on-error: true
if: github.repository == 'scikit-learn/scikit-learn'
with:
repo-token: "${{ secrets.GITHUB_TOKEN }}"
configuration-path: ".github/labeler-file-extensions.yml" |
There are a few stalled PRs related to implementations written Cython. They can be found, but indirectly searching for modules or specific words. I think this might also be useful from a triage and maintenance point of views, especially if retro-activity is possible as suggested by @thomasjpfan. @jeremiedbb, @ogrisel: would this be of your interest as well? |
Also move its configuration to a dedicated file.
Co-authored-by: "Thomas J. Fan" <thomasjpfan@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are a few stalled PRs related to implementations written Cython
Sorry, I meant feature request made to github (to enable searching by file extension), not to scikit-learn
I pushed 47210cc, the module labeler did work but not the new labeler as I assume it does not work as long as the new workflow config is not merged into main branch. I will undo my commit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM (assuming it works as expected ;)
Let's merge then, @jjerphan would you mind opening a new PR to test this out? |
@NicolasHug: there you go, #19884 kills two birds with one stone. |
I ran a script to label PRs with "cython" if they matched the glob. (There were 72 PRs) |
Thanks @thomasjpfan, @ogrisel and @NicolasHug for your quick inputs: this will helps other people and me in their work. 😉 |
Co-authored-by: "Thomas J. Fan" <thomasjpfan@gmail.com> Co-authored-by: Nicolas Hug <contact@nicolas-hug.com> Co-authored-by: Olivier Grisel <olivier.grisel@ensta.org>
What does this implement/fix? Explain your changes.
Parts of the code base rely on Cython code.
GitHub does not have a feature to navigate PRs based on extension of modified files.
This adds an entry to the labellers so that it makes contributions to Cython code browsable using a
cython
label.Any other comments?
As of now, this change is simple, but we might want to to have another another file to have the labelling definition for modules separated from this one.
Do you have any suggestions @thomasjpfan? 🙂