Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

CI Add label on PRs modifying Cython code #19850

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Apr 13, 2021

Conversation

jjerphan
Copy link
Member

@jjerphan jjerphan commented Apr 9, 2021

What does this implement/fix? Explain your changes.

Parts of the code base rely on Cython code.
GitHub does not have a feature to navigate PRs based on extension of modified files.

This adds an entry to the labellers so that it makes contributions to Cython code browsable using a cython label.

Any other comments?

As of now, this change is simple, but we might want to to have another another file to have the labelling definition for modules separated from this one.

Do you have any suggestions @thomasjpfan? 🙂

@NicolasHug
Copy link
Member

GitHub does not offer to navigate PR based on extension of modified files.

Ha that's a shame. Any existing feature request that we could +1 ?

Also I'm wondering: is the labeling retroactive and if it's not, is it still useful?

@thomasjpfan
Copy link
Member

Also I'm wondering: is the labeling retroactive and if it's not, is it still useful?

I can run a small script that does it once for all PRs, if we think the cython label is useful.

As for this PR, I would add another file for non-module related labeling named labeler-file-extensions.yml and add another job to:

My fork of the labeler puts a cap on the number of labels using the max-label config. We can remove the max-label cap for the "file-extensions" labeler.

jobs:
  triage_file_extensions:
    runs-on: ubuntu-latest
    steps:
    - uses: thomasjpfan/labeler@v2.5.0
      continue-on-error: true
      if: github.repository == 'scikit-learn/scikit-learn'
      with:
        repo-token: "${{ secrets.GITHUB_TOKEN }}"
        configuration-path: ".github/labeler-file-extensions.yml"

.github/labeler-module.yml Outdated Show resolved Hide resolved
@jjerphan
Copy link
Member Author

jjerphan commented Apr 9, 2021

Any existing feature request that we could +1 ?

There are a few stalled PRs related to implementations written Cython. They can be found, but indirectly searching for modules or specific words. I think this might also be useful from a triage and maintenance point of views, especially if retro-activity is possible as suggested by @thomasjpfan.

@jeremiedbb, @ogrisel: would this be of your interest as well?

jjerphan and others added 2 commits April 9, 2021 16:03
Also move its configuration to a dedicated file.
Co-authored-by: "Thomas J. Fan" <thomasjpfan@gmail.com>
Copy link
Member

@NicolasHug NicolasHug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are a few stalled PRs related to implementations written Cython

Sorry, I meant feature request made to github (to enable searching by file extension), not to scikit-learn

.github/labeler-file-extensions.yml Outdated Show resolved Hide resolved
jjerphan and others added 2 commits April 9, 2021 16:31
Co-authored-by: Nicolas Hug <contact@nicolas-hug.com>
@ogrisel
Copy link
Member

ogrisel commented Apr 13, 2021

I pushed 47210cc, the module labeler did work but not the new labeler as I assume it does not work as long as the new workflow config is not merged into main branch. I will undo my commit.

Copy link
Member

@ogrisel ogrisel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (assuming it works as expected ;)

@NicolasHug
Copy link
Member

Let's merge then, @jjerphan would you mind opening a new PR to test this out?

@NicolasHug NicolasHug merged commit bbdd3bb into scikit-learn:main Apr 13, 2021
@jjerphan jjerphan deleted the cython_labeler branch April 13, 2021 15:17
@jjerphan
Copy link
Member Author

@NicolasHug: there you go, #19884 kills two birds with one stone.

@thomasjpfan
Copy link
Member

I ran a script to label PRs with "cython" if they matched the glob. (There were 72 PRs)

@jjerphan
Copy link
Member Author

jjerphan commented Apr 13, 2021

Thanks @thomasjpfan, @ogrisel and @NicolasHug for your quick inputs: this will helps other people and me in their work. 😉

thomasjpfan added a commit to thomasjpfan/scikit-learn that referenced this pull request Apr 19, 2021
Co-authored-by: "Thomas J. Fan" <thomasjpfan@gmail.com>
Co-authored-by: Nicolas Hug <contact@nicolas-hug.com>
Co-authored-by: Olivier Grisel <olivier.grisel@ensta.org>
@glemaitre glemaitre mentioned this pull request Apr 22, 2021
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.