FIX BaseSuccessiveHalving class groups support #19847
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomDLT
approved these changes
Apr 8, 2021
|
Thanks @xiaoyuchai , this looks good. Would you mind adding a new non-regression test called HalvingRandomSearchCV and HalvingGridSearchCV? The new test should be in sklearn/model_selection/tests/test_successive_halving.py
|
|
We would also need a new |
|
Thanks, @NicolasHug . Yes, added testing method and documentation. Cheers! |
NicolasHug
approved these changes
Apr 10, 2021
There was a problem hiding this comment.
Thanks @xiaoyuchai , some last comments but LGTM when addressed!
|
Thanks @xiaoyuchai ! |
thomasjpfan
pushed a commit
to thomasjpfan/scikit-learn
that referenced
this pull request
Apr 19, 2021
Co-authored-by: Shawn <shawn@mpirica.com> Co-authored-by: Nicolas Hug <nicolashug@fb.com>
glemaitre
pushed a commit
to glemaitre/scikit-learn
that referenced
this pull request
Apr 22, 2021
Co-authored-by: Shawn <shawn@mpirica.com> Co-authored-by: Nicolas Hug <nicolashug@fb.com>
glemaitre
pushed a commit
that referenced
this pull request
Apr 28, 2021
Co-authored-by: Shawn <shawn@mpirica.com> Co-authored-by: Nicolas Hug <nicolashug@fb.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Fix #19841
What does this implement/fix? Explain your changes.
Enable groups in the fit method of BaseSuccessiveHalving class by revoking groups=None.
Any other comments?