Doc fix early stopping #19818
Merged
Doc fix early stopping #19818
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomasjpfan
reviewed
Apr 3, 2021
|
Co-authored-by: Thomas J. Fan <thomasjpfan@gmail.com>
ogrisel
approved these changes
Apr 14, 2021
There was a problem hiding this comment.
I slightly prefer my suggestion from #19818 (comment) but I am also fine with the current state of the PR.
|
Thanks for the PR @isaack-mungui , I agree with @ogrisel that his suggestion is more clear to users:
|
adrinjalali
approved these changes
Apr 19, 2021
thomasjpfan
added a commit
to thomasjpfan/scikit-learn
that referenced
this pull request
Apr 19, 2021
* Maintenance task: Moved PolynomialFeatures to _polynomial.py * Updated docstring including behaviour of neural network when early stopping is activated * Revert "Maintenance task: Moved PolynomialFeatures to _polynomial.py" This reverts commit f76df54. * reverted failing commit * Update sklearn/neural_network/_multilayer_perceptron.py Co-authored-by: Thomas J. Fan <thomasjpfan@gmail.com> * Updated doc with proposed changes * Fixed whitespace error Co-authored-by: Thomas J. Fan <thomasjpfan@gmail.com>
glemaitre
pushed a commit
to glemaitre/scikit-learn
that referenced
this pull request
Apr 22, 2021
* Maintenance task: Moved PolynomialFeatures to _polynomial.py * Updated docstring including behaviour of neural network when early stopping is activated * Revert "Maintenance task: Moved PolynomialFeatures to _polynomial.py" This reverts commit f76df54. * reverted failing commit * Update sklearn/neural_network/_multilayer_perceptron.py Co-authored-by: Thomas J. Fan <thomasjpfan@gmail.com> * Updated doc with proposed changes * Fixed whitespace error Co-authored-by: Thomas J. Fan <thomasjpfan@gmail.com>
glemaitre
pushed a commit
that referenced
this pull request
Apr 28, 2021
* Maintenance task: Moved PolynomialFeatures to _polynomial.py * Updated docstring including behaviour of neural network when early stopping is activated * Revert "Maintenance task: Moved PolynomialFeatures to _polynomial.py" This reverts commit f76df54. * reverted failing commit * Update sklearn/neural_network/_multilayer_perceptron.py Co-authored-by: Thomas J. Fan <thomasjpfan@gmail.com> * Updated doc with proposed changes * Fixed whitespace error Co-authored-by: Thomas J. Fan <thomasjpfan@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Towards #19743
What does this implement/fix? Explain your changes.
Highlights the behaviour of a neural network if early_stopping is activated: in this case, validation score is used to stop the neural network. Otherwise, loss is used.