Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

FIX Approximate nearest neighbors in TSNE example #19809

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 2, 2021
Merged

FIX Approximate nearest neighbors in TSNE example #19809

merged 2 commits into from
Apr 2, 2021

Conversation

TomDLT
Copy link
Member

@TomDLT TomDLT commented Apr 1, 2021

Fixes #19808 (use fetch_openml with as_frame=False)

Also update the example to use TSNE with square_distances=True (added in #17662).

@TomDLT TomDLT changed the title Example FIX Approximate nearest neighbors in TSNE example Apr 1, 2021
thomasjpfan
thomasjpfan approved these changes Apr 2, 2021
View reviewed changes
Copy link
Member

@thomasjpfan thomasjpfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jeremiedbb
jeremiedbb approved these changes Apr 2, 2021
View reviewed changes
Copy link
Member

@jeremiedbb jeremiedbb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @TomDLT !

@jeremiedbb jeremiedbb merged commit a9ae693 into scikit-learn:main Apr 2, 2021
@glemaitre glemaitre mentioned this pull request Apr 22, 2021
Merged
12 tasks
glemaitre pushed a commit to glemaitre/scikit-learn that referenced this pull request Apr 22, 2021
@TomDLT @glemaitre
FIX Approximate nearest neighbors in TSNE example (scikit-learn#19809)
d7052d7
glemaitre pushed a commit that referenced this pull request Apr 28, 2021
@TomDLT @glemaitre
FIX Approximate nearest neighbors in TSNE example (#19809)
2114559
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomasjpfan thomasjpfan thomasjpfan approved these changes

@jeremiedbb jeremiedbb jeremiedbb approved these changes

Assignees
No one assigned
Labels
No Changelog Needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Example: Approximate nearest neighbors in TSNE
3 participants
@TomDLT @thomasjpfan @jeremiedbb
Morty Proxy This is a proxified and sanitized view of the page, visit original site.