DOC Clarify documentation for spectral clustering #19795
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All-around improvements for clarity. Probably the most important change is clarifying what affinity="precomputed_nearest_neighbors" actually means.
|
@thomasjpfan Any chance this can be merged soon? |
thomasjpfan
reviewed
Apr 13, 2021
Also fixes linter complaint about line too long
thomasjpfan
pushed a commit
to thomasjpfan/scikit-learn
that referenced
this pull request
Apr 19, 2021
glemaitre
pushed a commit
to glemaitre/scikit-learn
that referenced
this pull request
Apr 22, 2021
glemaitre
pushed a commit
that referenced
this pull request
Apr 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All-around improvements for clarity. Probably the most important change is clarifying what setting
affinity="precomputed_nearest_neighbors"actually means.