Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

ENH num_features for a 1d collection of dicts is undefined #19740

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 29, 2021
Merged

ENH num_features for a 1d collection of dicts is undefined #19740

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0a12d7a
ENH num_features for dicts is undefined
thomasjpfan Mar 21, 2021
9d00fe7
Update sklearn/utils/validation.py
thomasjpfan Mar 23, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions 7 sklearn/utils/tests/test_validation.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1345,9 +1345,10 @@ def test_num_features(constructor_name):
[1, 2, 3],
["a", "b", "c"],
[False, True, False],
[1.0, 3.4, 4.0]
[1.0, 3.4, 4.0],
[{"a": 1}, {"b": 2}, {"c": 3}],
],
ids=["int", "str", "bool", "float"]
ids=["int", "str", "bool", "float", "dict"]
)
@pytest.mark.parametrize("constructor_name", [
"list", "tuple", "array", "series"
Expand All @@ -1368,6 +1369,8 @@ def test_num_features_errors_1d_containers(X, constructor_name):
message += " with shape (3,)"
elif isinstance(X[0], str):
message += " where the samples are of type str"
elif isinstance(X[0], dict):
message += " where the samples are of type dict"
with pytest.raises(TypeError, match=re.escape(message)):
_num_features(X)

Expand Down
4 changes: 2 additions & 2 deletions 4 sklearn/utils/validation.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -226,8 +226,8 @@ def _num_features(X):

first_sample = X[0]

# Do not consider an array-like of strings to be a 2D array
if isinstance(first_sample, (str, bytes)):
# Do not consider an array-like of strings or dicts to be a 2D array
if isinstance(first_sample, (str, bytes, dict)):
message += (f" where the samples are of type "
f"{type(first_sample).__qualname__}")
raise TypeError(message)
Expand Down
Morty Proxy This is a proxified and sanitized view of the page, visit original site.