DOC Fix doc for single linkage in feature agglomeration #19715
Conversation
There was a problem hiding this comment.
Thank you for the PR @cliffordEmmanuel !
The documentation for AgglomerativeClustering does not need to change. We update it for FeatureAgglomeration.
|
For future PRs, try to create a title that describes the changes more explicitly. The title will become the git commit message when we merge the PR. |
Thank you @thomasjpfan for the feedback, I will make this and future titles more descriptive |
Yup we need to update the docstring for |
Thank you I'll roll back this change and update the featureAgglomeration instead. |
|
Hi @thomasjpfan I'm unsure where to locate the FeatureAgglomeration docstring, I'm currently looking at the sklearn/doc/modules/clustering.rst. Could you please advise on what to do? I think I'm pretty clueless on this |
|
You can use your editor and search for "class FeatureAgglomeration" to find the location of a class or go to the api docs and click the "source" |
|
Thank you @thomasjpfan, this is way faster than the ctrl+shift+f I was using |
Reference Issues/PRs
Fixes #15259
What does this implement/fix? Explain your changes.
Changes the description of the 'single' value for the linkage parameter for the feature agglomeration function from 'single uses the minimum of the distances between all observations of the two sets.' to 'single uses the minimum of the distances between all features of the two sets.'
Any other comments?