Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

MAINT Improve issue template #19704

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 23, 2021
Merged

Conversation

lesteve
Copy link
Member

@lesteve lesteve commented Mar 17, 2021

Reference Issues/PRs

Close #19700

What does this implement/fix? Explain your changes.

Encourage using Github Discussions rather than Blank issue template.

  • remove Other template
  • replace Other by Blank issue at the very bottom
  • small minor tweaks

* remove Other in favor of discussions
* replace Other by Blank issue at the very bottom
@lesteve
Copy link
Member Author

lesteve commented Mar 17, 2021

The way it looks on a test repo: https://github.com/lesteve/test/issues/new/choose

image

.github/ISSUE_TEMPLATE/config.yml Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/config.yml Outdated Show resolved Hide resolved
lesteve and others added 3 commits March 17, 2021 15:27
Co-authored-by: Thomas J. Fan <thomasjpfan@gmail.com>
Co-authored-by: Thomas J. Fan <thomasjpfan@gmail.com>
Copy link
Member

@thomasjpfan thomasjpfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thomasjpfan thomasjpfan changed the title Improve issue template. MAINT Improve issue template Mar 17, 2021
@cmarmo
Copy link
Contributor

cmarmo commented Mar 23, 2021

Hello @lesteve, two approvals: shall this be merged?

@rth rth merged commit 5788d4a into scikit-learn:main Mar 23, 2021
@lesteve
Copy link
Member Author

lesteve commented Mar 23, 2021

Thanks!

@glemaitre glemaitre mentioned this pull request Apr 22, 2021
12 tasks
@lesteve lesteve deleted the enh-issue-template branch March 31, 2023 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[RFC] Removing "Other" template in favour of Github Discussions?
4 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.