[MRG] Fix documentation for russelrao formula #19695
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update the russelrao description to match the implementation and third-party sources
jeremiedbb
approved these changes
Mar 16, 2021
There was a problem hiding this comment.
It corresponds indeed to the definition in scipy and to the implementation
|
Merging thanks a lot! Small tip for your next PR: you can use "Fix #issueNumber" in your PR description (i.e. not your PR title), this way the associated issue gets closed automatically when the PR is merged. For more details, look at this. |
marrodion
pushed a commit
to marrodion/scikit-learn
that referenced
this pull request
Mar 17, 2021
glemaitre
pushed a commit
to glemaitre/scikit-learn
that referenced
this pull request
Apr 22, 2021
glemaitre
pushed a commit
that referenced
this pull request
Apr 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the russelrao description to match the implementation and third-party documentation of the algorithm