ENH Deprecated the default random_state=0 in randomized_svd #19670
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomasjpfan
reviewed
Mar 13, 2021
|
Thank you @thomasjpfan |
Co-authored-by: Thomas J. Fan <thomasjpfan@gmail.com>
|
Hi, @thomasjpfan can you please advise on the Changelog Check. It seems to fail every time. |
thomasjpfan
approved these changes
Mar 13, 2021
Co-authored-by: Thomas J. Fan <thomasjpfan@gmail.com>
rth
approved these changes
Mar 15, 2021
|
Thank you all, this has been my first attempt at this and I'm really grateful for the experience. |
|
Congrats @cliffordEmmanuel! |
|
#DataUmbrella |
|
Oh wow thanks Clifford for finishing this off for us!
…________________________________
From: cliffordEmmanuel ***@***.***>
Sent: Monday, March 15, 2021 1:50 PM
To: scikit-learn/scikit-learn ***@***.***>
Cc: Cindy Bezuidenhout ***@***.***>; Mention ***@***.***>
Subject: Re: [scikit-learn/scikit-learn] ENH Deprecated the default random_state=0 in randomized_svd (#19670)
Thank you all, this has been my first attempt at this and I'm really grateful for the experience.
Moving on to find another.... :)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub<#19670 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AFQLTTYCCMWQ5OEZ7TD6N4LTDXYATANCNFSM4ZDSPWLQ>.
|
marrodion
pushed a commit
to marrodion/scikit-learn
that referenced
this pull request
Mar 17, 2021
…earn#19670) Co-authored-by: Thomas J. Fan <thomasjpfan@gmail.com> Co-authored-by: cinbez <cindyb@lightstone.co.za>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Fixes #18584
Closes #19459
Closes #19370
What does this implement/fix? Explain your changes.
Fixes the default value of random state in the randomized_svd function and provides a deprecation warning should the value not be provided. If random_state is not supplied, the current default is to use 0 as a fixed seed. This will change to None in version 1.2 leading to non-deterministic results that better reflect the nature of the randomized_svd solver.
Any other comments?
Thanks to @cinbez for her initial work on this