MNT Remove absolute imports #19668
Merged
MNT Remove absolute imports #19668
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomasjpfan
approved these changes
Mar 12, 2021
There was a problem hiding this comment.
Thank you for the PR @MarcoGorelli !
I would prefer not to have the absolufy-imports check for now.
|
Fair enough, thanks for your approval, this was really useful to test it out on (I didn't know that |
lorentzenchr
approved these changes
Mar 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Issue #13629 asked to remove absolute imports - however, it looks like there's still a few around
What does this implement/fix? Explain your changes.
Converts the remaining absolute imports (excluding those in tests and setup.py files) to relative
Any other comments?
I found these while testing out absolufy-imports, which I ran with the
--neverflag. I could add this to the CI lint checks if you find it useful