Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

MNT Make setup.py command parsing more robust #19650

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 10, 2021
Merged

Conversation

geofft
Copy link
Contributor

@geofft geofft commented Mar 8, 2021

Separate arguments into options and commands, and use setuptools.setup
if all the requested commands can / should run without NumPy installed,
even if there are options present.

This fixes a bug where setup.py --no-user-site egg_info wants NumPy to
be installed, even though setup.py egg_info works fine.

Separate arguments into options and commands, and use setuptools.setup
if all the requested commands can / should run without NumPy installed,
even if there are options present.

This fixes a bug where `setup.py --no-user-site egg_info` wants NumPy to
be installed, even though `setup.py egg_info` works fine.
Copy link
Member

@jnothman jnothman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still not semantically precise, but definitely an improvement.

Copy link
Member

@rth rth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @geofft !

@rth rth merged commit 4beb0c2 into scikit-learn:main Mar 10, 2021
@glemaitre glemaitre mentioned this pull request Apr 22, 2021
12 tasks
glemaitre pushed a commit to glemaitre/scikit-learn that referenced this pull request Apr 22, 2021
Separate arguments into options and commands, and use setuptools.setup
if all the requested commands can / should run without NumPy installed,
even if there are options present.

This fixes a bug where `setup.py --no-user-site egg_info` wants NumPy to
be installed, even though `setup.py egg_info` works fine.
glemaitre pushed a commit that referenced this pull request Apr 28, 2021
Separate arguments into options and commands, and use setuptools.setup
if all the requested commands can / should run without NumPy installed,
even if there are options present.

This fixes a bug where `setup.py --no-user-site egg_info` wants NumPy to
be installed, even though `setup.py egg_info` works fine.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.