Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

TST replaces assert_raises* by pytest.raises in model_selection/tests/test_split.py #19585

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

mohaseeb
Copy link
Contributor

@mohaseeb mohaseeb commented Mar 1, 2021

Reference Issues/PRs

References #14216. This finalizes the work on PR #19375

What does this implement/fix? Explain your changes.

Replaces the use of assert_raises* with pytest.raises in model_selection/tests/test_split.py

Any other comments?

#DataUmbrella
cc: (pair programming partner) @cycks

@mohaseeb
Copy link
Contributor Author

mohaseeb commented Mar 1, 2021

Any suggestions how to handle the Changelog check failure?

@ogrisel
Copy link
Member

ogrisel commented Mar 1, 2021

This PR does not need a changelog entry because it does not change the behavior of the library. I added the label to skip this check.

Copy link
Member

@ogrisel ogrisel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @mohaseeb!

Copy link
Member

@lorentzenchr lorentzenchr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @mohaseeb.

@lorentzenchr lorentzenchr merged commit 72db93c into scikit-learn:main Mar 1, 2021
@glemaitre glemaitre mentioned this pull request Apr 22, 2021
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.