Change assert from sklearn to pytest style in module linear_model/tests #19565
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8a85f7b to
3be8587
Compare
ogrisel
approved these changes
Feb 26, 2021
lorentzenchr
approved these changes
Feb 27, 2021
There was a problem hiding this comment.
LGTM. We can merge with or without my one suggestion.
@shivamgargsya Thanks.
Comment on lines
1197
to
1221
| warning_messages = { | ||
| 'newton-cg': ( | ||
| "newton-cg failed to converge. Increase the" | ||
| " number of iterations." | ||
| ), | ||
| 'liblinear': ( | ||
| "Liblinear failed to converge, increase the" | ||
| " number of iterations." | ||
| ), | ||
| 'sag': ( | ||
| "The max_iter was reached which means the" | ||
| " coef_ did not converge" | ||
| ), | ||
| 'saga': ( | ||
| "The max_iter was reached which means the" | ||
| " coef_ did not converge" | ||
| ), | ||
| 'lbfgs': ( | ||
| r"lbfgs failed to converge .*[\n]*.*[\n]*" | ||
| r"Increase the number of iterations.*" | ||
| r"or scale the data.*[\n]*.*[\n]*" | ||
| r"Please also refer to the documentation " | ||
| r"for alternative solver options.*[\n]*.*" | ||
| ) | ||
| } |
There was a problem hiding this comment.
I would prefer to @pytest.mark.parametrize this test with max_iter, multi_class and [solver, message].
jeremiedbb
approved these changes
Mar 12, 2021
There was a problem hiding this comment.
lgtm. I directly pushed the requested changes. I'll merge on green. Thanks @shivamgargsya !
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Part of #19414 for linear_model/tests
What does this implement/fix? Explain your changes.
Removed use of assert_warns, assert_warns_message in linear_model/tests package
Any other comments?
The fix is part of complete fix for issue #19414