Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

DOC Fix documentation on pickle portability #19561

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 27, 2021

Conversation

rth
Copy link
Member

@rth rth commented Feb 25, 2021

Reformulates the section on cross-platform portability of pickles,

  • pickles are generally portable across platforms, and in rare cases when estimators aren't (because of custom low level structures) I think we should consider it as a bug and fix when possible (as was done in Fixed a cross-platform endian issue #17644 for instance). It shouldn't be too difficult, particularly that we don't have backward compatibility constraints on pickles. Though the issue is more that it's difficult to test this as part of CI. Otherwise there is no way to deploy a model trained on x86_64 to arm64, aside maybe from using ONNX which has other constraints.
  • Docker cannot be used for cross platform portability but is rather used to freeze the environment for a given architecture.

cc @ogrisel

doc/modules/model_persistence.rst Outdated Show resolved Hide resolved
Co-authored-by: Olivier Grisel <olivier.grisel@ensta.org>
Copy link
Member

@thomasjpfan thomasjpfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the doc fix @rth

LGTM!

@thomasjpfan thomasjpfan merged commit e0f0c7f into scikit-learn:main Feb 27, 2021
@rth rth deleted the fix-deployement-docs branch February 27, 2021 07:44
@glemaitre glemaitre mentioned this pull request Apr 22, 2021
12 tasks
glemaitre pushed a commit to glemaitre/scikit-learn that referenced this pull request Apr 22, 2021
Co-authored-by: Olivier Grisel <olivier.grisel@ensta.org>
glemaitre pushed a commit that referenced this pull request Apr 28, 2021
Co-authored-by: Olivier Grisel <olivier.grisel@ensta.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.