-
-
Notifications
You must be signed in to change notification settings - Fork 25.9k
CI Use conda instead of pip to install anaconda-client #19528
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do not have a strong opinion on this. Since the anaconda-client package is python-only, installing from git seems okay with me.
In the travis case, downloading and install miniforge would add a little bit of time to the build and I think we want to conserve our credits there.
I tried to install Nevertheless, I ran: pip install git+https://github.com/Anaconda-Platform/anaconda-project
pip install git+https://github.com/Anaconda-Platform/anaconda-client in my machine and it works. Not sure what is the problem in |
Ah I see, if installing with anaconda-client from conda fixes a bug, then I am +1 with this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM if you re-rerun [cd build]
after the last commit just to make sure that it works with the the current state of the PR.
Actually, I am confused, none of the above
so maybe the the command-line parsing has changed. You can test it locally by creating your own personal anaconda.org channel. |
Sorry for the late reply. The actual problem is that Let me check for a personal project. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the status of this @alfaro96? Does it works on the CI configured on your repo?
MINICONDA_URL="https://github.com/conda-forge/miniforge/releases/latest/download/Miniforge3-Linux-aarch64.sh" | ||
wget $MINICONDA_URL -O miniconda.sh | ||
MINICONDA_PATH=$HOME/miniconda | ||
chmod +x miniconda.sh && ./miniconda.sh -b -p $MINICONDA_PATH |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Better name this MINIFORGE_URL
and miniforge.sh
to avoid confusion.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not getting your point 😕.
Let me run the |
Here is the workflow: https://github.com/alfaro96/scikit-learn/runs/2115411152?check_suite_focus=true. It is failing, but I think that it is related with the token. Edit: I have figured out that the error was related with a bug in Python 3.9. I have downgraded to Python 3.8 and it is working. Here is the working run: https://github.com/alfaro96/scikit-learn/actions/runs/657229124. |
This is actually failing:
|
Yep, I have committed a new version that I hope does not fail 😅. Let us wait for the https://github.com/alfaro96/scikit-learn/actions/runs/657229124 to finish and, if it works, I will clean the files changed 😉. |
Okay, the workflow (https://github.com/alfaro96/scikit-learn/actions/runs/657229124) is working and the wheels properly uploaded to the corresponding index: https://pypi.anaconda.org/alfaro96/simple/scikit-learn/. Let me clean the files changed for preparing to merge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, let's merge to give it a try for the next nightly builds uploads.
Thank you very much @alfaro96. |
What does this implement/fix? Explain your changes.
This PR fixes the
Wheel builder
workflow. I decided to use the recommended option, that is, installanaconda-client
usingconda
.