Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

DOC Fixed typos in documentation #19511

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 20, 2021
Merged

Conversation

Ashish013
Copy link
Contributor

This pull request fixes a typo in the documentation of sklearn.model_selection.GridSearchCV.

Copy link
Member

@thomasjpfan thomasjpfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR @Ashish013 !

May you fix the same typo in the following places as well?

sklearn/inspection/_permutation_importance.py:118:        If `scoring` reprents multiple scores, one can use:
sklearn/model_selection/_search.py:1349:        If `scoring` reprents multiple scores, one can use:
sklearn/model_selection/_validation.py:77:        If `scoring` reprents multiple scores, one can use:

@Ashish013 Ashish013 changed the title Fixed a typo in GridSearchCV Fixed typos in documentation Feb 20, 2021
Copy link
Member

@thomasjpfan thomasjpfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thomasjpfan thomasjpfan changed the title Fixed typos in documentation DOC Fixed typos in documentation Feb 20, 2021
@thomasjpfan thomasjpfan merged commit 70c6ac9 into scikit-learn:main Feb 20, 2021
@thomasjpfan
Copy link
Member

Thank you for the contribution @Ashish013 !

@glemaitre glemaitre mentioned this pull request Apr 22, 2021
12 tasks
glemaitre pushed a commit to glemaitre/scikit-learn that referenced this pull request Apr 22, 2021
glemaitre pushed a commit that referenced this pull request Apr 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.